trezor / blockbook

:blue_book: Trezor address/account balance backend
https://trezor.io
GNU Affero General Public License v3.0
651 stars 647 forks source link

Error at more than witness v1 address #376

Closed wakiyamap closed 2 years ago

wakiyamap commented 4 years ago

https://btc.blockbook.api.openbazaar.org/address/bc1pw508d6qejxtdg4y5r3zarvary0c5xw7kw508d6qejxtdg4y5r3zarvary0c5xw7k7grplx

https://blockstream.info/address/bc1pw508d6qejxtdg4y5r3zarvary0c5xw7kw508d6qejxtdg4y5r3zarvary0c5xw7k7grplx

Probably because btcutil does not support without witness v0 address. Is there a plan to support it?

martinboehm commented 4 years ago

Is any other than version 0 witness program in use? Does it make sense to support it? Btw the error handling is incorrect as it does not show the detected version, I will fix that part.

wakiyamap commented 4 years ago

I think it isn't necessary at this time too. I was asked a question, and as a result of investigation, btcutil seemed to be the cause.

Thanks.

wakiyamap commented 3 years ago

taproot address is version 1 witness program. https://signet-explorer.wakiyamap.dev/tx/06ae72d6c6b789af245f0a8438eb70d7d61f70b267cf770e8697e0281460510f https://explorer.bc-2.jp/tx/06ae72d6c6b789af245f0a8438eb70d7d61f70b267cf770e8697e0281460510f

I think probably it work allowing witness v1 and len(witnessProg)==32. https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki

It needs to be fixed that newAddressWitnessPubKeyHash returns a fixed hardcoded version 00.

gruve-p commented 3 years ago

Taproot will be introduced to BTC as a softfork this year. GRS has already activated taproot on testnet and we have the same issue: https://blockbook-test.groestlcoin.org/tx/dce4f38b71e8b9e6715aba939d8eabf5a9c9d70bd983e3cfeaf8bd164937fc19 as reported by OP. Sooner or later version 1 witness program will need to be supported in Blockbook.

martinboehm commented 3 years ago

Hi. We are aware of the issue, we will handle it in the future release.

martinboehm commented 2 years ago

Taproot is supported in v0.3.6

gruve-p commented 2 years ago

@martinboehm

Building v0.3.6 has lots of warnings:

Step 20/25 : RUN cd /opt/rocksdb && CFLAGS=-fPIC CXXFLAGS=-fPIC make -j 4 release
 ---> Running in 3abdc1844661
$DEBUG_LEVEL is 0
$DEBUG_LEVEL is 0
rm -rf bzip2* snappy* zlib* lz4* zstd*
echo shared=librocksdb.so librocksdb.so.6 librocksdb.so.6.22 librocksdb.so.6.22.1 librocksdb_test.so librocksdb_tools.so librocksdb_stress.so
rm -rf jl jls
shared=librocksdb.so librocksdb.so.6 librocksdb.so.6.22 librocksdb.so.6.22.1 librocksdb_test.so librocksdb_tools.so librocksdb_stress.so
cd java && make clean
echo static=librocksdb.a librocksdb_test.a librocksdb_tools.a librocksdb_stress.a
static=librocksdb.a librocksdb_test.a librocksdb_tools.a librocksdb_stress.a
make[1]: Entering directory '/opt/rocksdb/java'
rm -f  cache_bench  range_del_aggregator_bench  memtablerep_bench  table_reader_bench  db_bench  filter_bench  persistent_cache_bench  db_stress  blob_dump  block_cache_trace_analyzer  db_repl_stress  db_sanity_test  ldb  io_tracer_parser  sst_dump  write_stress  rocksdb_dump  rocksdb_undump  trace_analyzer  io_tracer_parser  cache_test  lru_cache_test  blob_file_addition_test  blob_file_builder_test  blob_file_cache_test  blob_file_garbage_test  blob_file_reader_test  db_blob_basic_test  db_blob_compaction_test  db_blob_corruption_test  db_blob_index_test  column_family_test  compact_files_test  clipping_iterator_test  compaction_iterator_test  compaction_job_test  compaction_job_stats_test  compaction_picker_test  compaction_service_test  comparator_db_test  corruption_test  cuckoo_table_db_test  db_basic_test  db_with_timestamp_basic_test  db_block_cache_test  db_bloom_filter_test  db_compaction_filter_test  db_compaction_test  db_dynamic_level_test  db_encryption_test  db_flush_test  import_column_family_test  db_inplace_update_test  db_io_failure_test  db_iter_test  db_iter_stress_test  db_iterator_test  db_kv_checksum_test  db_log_iter_test  db_memtable_test  db_merge_operator_test  db_merge_operand_test  db_options_test  db_properties_test  db_range_del_test  db_secondary_test  db_sst_test  db_statistics_test  db_table_properties_test  db_tailing_iter_test  db_test  db_test2  db_logical_block_size_cache_test  db_universal_compaction_test  db_wal_test  db_with_timestamp_compaction_test  db_write_buffer_manager_test  db_write_test  dbformat_test  deletefile_test  error_handler_fs_test  external_sst_file_basic_test  external_sst_file_test  fault_injection_test  file_indexer_test  filename_test  flush_job_test  listener_test  log_test  manual_compaction_test  memtable_list_test  merge_helper_test  merge_test  obsolete_files_test  options_file_test  perf_context_test  periodic_work_scheduler_test  plain_table_db_test  prefix_test  repair_test  range_del_aggregator_test  range_tombstone_fragmenter_test  table_properties_collector_test  version_builder_test  version_edit_test  version_set_test  wal_manager_test  write_batch_test  write_callback_test  write_controller_test  env_basic_test  env_test  io_posix_test  mock_env_test  delete_scheduler_test  prefetch_test  random_access_file_reader_test  auto_roll_logger_test  env_logger_test  event_logger_test  arena_test  memkind_kmem_allocator_test  inlineskiplist_test  skiplist_test  write_buffer_manager_test  histogram_test  iostats_context_test  statistics_test  stats_history_test  configurable_test  customizable_test  options_settable_test  options_test  block_based_filter_block_test  block_based_table_reader_test  block_test  data_block_hash_index_test  full_filter_block_test  partitioned_filter_block_test  cleanable_test  cuckoo_table_builder_test  cuckoo_table_reader_test  merger_test  sst_file_reader_test  table_test  block_fetcher_test  testutil_test  block_cache_trace_analyzer_test  io_tracer_parser_test  ldb_cmd_test  reduce_levels_test  sst_dump_test  trace_analyzer_test  block_cache_tracer_test  io_tracer_test  autovector_test  bloom_test  coding_test  crc32c_test  defer_test  dynamic_bloom_test  filelock_test  file_reader_writer_test  hash_test  heap_test  random_test  rate_limiter_test  repeatable_thread_test  ribbon_test  slice_test  slice_transform_test  timer_queue_test  timer_test  thread_list_test  thread_local_test  work_queue_test  backupable_db_test  blob_db_test  cassandra_format_test  cassandra_functional_test  cassandra_row_merge_test  cassandra_serialize_test  checkpoint_test  env_timed_test  memory_test  stringappend_test  object_registry_test  option_change_migration_test  options_util_test  hash_table_test  persistent_cache_test  cache_simulator_test  sim_cache_test  compact_on_deletion_collector_test  optimistic_transaction_test  range_locking_test  transaction_test  point_lock_manager_test  write_prepared_transaction_test  write_unprepared_transaction_test  ttl_test  util_merge_operators_test  write_batch_with_index_test  c_test folly_synchronization_distributed_mutex_test cache_test lru_cache_test blob_file_addition_test blob_file_builder_test blob_file_cache_test blob_file_garbage_test blob_file_reader_test db_blob_basic_test db_blob_compaction_test db_blob_corruption_test db_blob_index_test column_family_test compact_files_test clipping_iterator_test compaction_iterator_test compaction_job_test compaction_job_stats_test compaction_picker_test compaction_service_test comparator_db_test corruption_test cuckoo_table_db_test db_basic_test db_with_timestamp_basic_test db_block_cache_test db_bloom_filter_test db_compaction_filter_test db_compaction_test db_dynamic_level_test db_encryption_test db_flush_test import_column_family_test db_inplace_update_test db_io_failure_test db_iter_test db_iter_stress_test db_iterator_test db_kv_checksum_test db_log_iter_test db_memtable_test db_merge_operator_test db_merge_operand_test db_options_test db_properties_test db_range_del_test db_secondary_test db_sst_test db_statistics_test db_table_properties_test db_tailing_iter_test db_test db_test2 db_logical_block_size_cache_test db_universal_compaction_test db_wal_test db_with_timestamp_compaction_test db_write_buffer_manager_test db_write_test dbformat_test error_handler_fs_test external_sst_file_basic_test external_sst_file_test fault_injection_test file_indexer_test filename_test flush_job_test listener_test log_test manual_compaction_test memtable_list_test merge_helper_test merge_test obsolete_files_test options_file_test perf_context_test periodic_work_scheduler_test plain_table_db_test prefix_test repair_test range_del_aggregator_test range_tombstone_fragmenter_test table_properties_collector_test version_builder_test version_edit_test version_set_test wal_manager_test write_batch_test write_callback_test write_controller_test env_basic_test io_posix_test mock_env_test delete_scheduler_test prefetch_test random_access_file_reader_test auto_roll_logger_test env_logger_test event_logger_test arena_test memkind_kmem_allocator_test inlineskiplist_test skiplist_test write_buffer_manager_test histogram_test iostats_context_test statistics_test stats_history_test configurable_test customizable_test options_settable_test options_test block_based_filter_block_test block_based_table_reader_test block_test data_block_hash_index_test full_filter_block_test partitioned_filter_block_test cleanable_test cuckoo_table_builder_test cuckoo_table_reader_test merger_test sst_file_reader_test table_test block_fetcher_test testutil_test block_cache_trace_analyzer_test io_tracer_parser_test ldb_cmd_test reduce_levels_test sst_dump_test trace_analyzer_test block_cache_tracer_test io_tracer_test autovector_test bloom_test coding_test crc32c_test defer_test dynamic_bloom_test filelock_test file_reader_writer_test hash_test heap_test random_test rate_limiter_test repeatable_thread_test ribbon_test slice_test slice_transform_test timer_queue_test timer_test thread_list_test thread_local_test work_queue_test backupable_db_test blob_db_test cassandra_format_test cassandra_functional_test cassandra_row_merge_test cassandra_serialize_test checkpoint_test env_timed_test memory_test stringappend_test object_registry_test option_change_migration_test options_util_test hash_table_test persistent_cache_test cache_simulator_test sim_cache_test compact_on_deletion_collector_test optimistic_transaction_test range_locking_test transaction_test point_lock_manager_test write_prepared_transaction_test write_unprepared_transaction_test ttl_test util_merge_operators_test write_batch_with_index_test c_test folly_synchronization_distributed_mutex_test librocksdb.a librocksdb_test.a librocksdb_tools.a librocksdb_stress.a librocksdb.so librocksdb.so.6 librocksdb.so.6.22 librocksdb.so.6.22.1 librocksdb_test.so librocksdb_tools.so librocksdb_stress.so
rm -rf  make_config.mk rocksdb.pc util/build_version.cc t LOG /dev/shm/rocksdb.rVj0 unity.cc ios-x86 ios-arm scan_build_report
find . -name "*.[oda]" -exec rm -f {} \;
rm -rf ./include
rm -rf test-libs
rm -rf target
rm -rf benchmark/target
rm -rf samples/target
make[1]: Leaving directory '/opt/rocksdb/java'
find . -type f -regex ".*\.\(\(gcda\)\|\(gcno\)\)" -exec rm -f {} \;
LIB_MODE=static DEBUG_LEVEL=0 make librocksdb.a tools db_bench
make[1]: Entering directory '/opt/rocksdb'
$DEBUG_LEVEL is 0
Makefile:268: Warning: /gtest-1.8.1/fused-src does not exist
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++

OS: Distributor ID: Debian Description: Debian GNU/Linux 9.13 (stretch) Release: 9.13 Codename: stretch

GCC: Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/6/lto-wrapper Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Debian 6.3.0-18+deb9u1' --with-bugurl=file:///usr/share/doc/gcc-6/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-6 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-6-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-6-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-6-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu Thread model: posix gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1)

Docker: Docker version 19.03.15, build 99e3ed8919

martinboehm commented 2 years ago

Strange, our docker build on debian 10 works fine. Maybe cleanup all docker caches (run make clean-all)

gruve-p commented 2 years ago

@martinboehm Already tried to run make clean-all but had no effect. I would prefer not to upgrade debian 9 to 10 but if thats the only solution then I can give it a go.

It seems related to this issue: https://github.com/facebook/rocksdb/issues/8286

gruve-p commented 2 years ago

Just tested on another Debian 9 machine and same behavior. However this time I left it running to see what happens. It continues to compile blockbook with a warning every single line:

$DEBUG_LEVEL is 0
Makefile:268: Warning: /gtest-1.8.1/fused-src does not exist
  CC       cache/cache.o
  CC       cache/cache_entry_roles.o
  CC       cache/clock_cache.o
  CC       cache/lru_cache.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       cache/sharded_cache.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/arena_wrapped_db_iter.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/blob/blob_fetcher.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/blob/blob_file_addition.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/blob/blob_file_builder.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/blob/blob_file_cache.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/blob/blob_file_garbage.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/blob/blob_file_meta.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/blob/blob_file_reader.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/blob/blob_log_format.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/blob/blob_log_sequential_reader.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/blob/blob_log_writer.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/builder.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/c.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/column_family.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/compaction/compaction.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/compaction/compaction_iterator.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/compaction/compaction_job.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/compaction/compaction_picker.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/compaction/compaction_picker_fifo.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/compaction/compaction_picker_level.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/compaction/compaction_picker_universal.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/compaction/sst_partitioner.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/convenience.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/db_filesnapshot.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/db_impl/compacted_db_impl.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/db_impl/db_impl.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/db_impl/db_impl_compaction_flush.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/db_impl/db_impl_debug.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/db_impl/db_impl_experimental.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/db_impl/db_impl_files.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
  CC       db/db_impl/db_impl_open.o
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++

Eventually it finishes compiling.

gruve-p commented 2 years ago

Taproot addresses are working fine now !

GRS testnet: https://blockbook-test.groestlcoin.org/tx/dce4f38b71e8b9e6715aba939d8eabf5a9c9d70bd983e3cfeaf8bd164937fc19

GRS mainnet: https://blockbook.groestlcoin.org/tx/4726287db608e1b6b04fda6dcb346713b6207eb43566e9c343e842969647fd1e

Not sure if taproot xpub descriptors are working fine for GRS

martinboehm commented 2 years ago

Great! I assume that the build went OK after all.