ci: Refactor GitHub Actions CI so Node v12, v14, v16 are tested

[aloisklink]

I noticed that your GitHub Actions CI didn't catch https://github.com/trezor/trezor-suite/issues/5107, so since I was already familiar with your CI (due to https://github.com/trezor/connect/pull/1050 (may cause merge conflicts)), I thought I'd fix it.

The issue with the previous GitHub Action is that actions/setup-node@v2 for Node v12 was only called in the setup job. Each job in GitHub CI is called on a different VM, so every other job defaulted to Node v16.

Although I could have just copied that setup action to every single job, to avoid code reuse, I've refactored all of the .github/workflows/test* files into:

• .github/workflows/test.yml, which is started on a push/pull_request to the develop branch.
• .github/workflows/test_with_trezor-user-env.yml, a workflow that's called from .github/workflows/test.yml, which contains all of the reusable code that runs trezor_user_env and then the test calls in Node v12, v14, v16, and karma.

Behavior changes:

• Instead of using a custom call to cache the node_modules folder (not guaranteed to be cross-compatible across Node.js versions), I'm using the recommended built-in of actions/setup-node
• Node.JS tests are now run on Node v12, v14, v16 in parallel (maybe fixes https://github.com/trezor/trezor-suite/issues/5111)
• karma tests are run only on Node v12, since I believe they're browser based, so don't need to be run on multiple Node versions.
• Instead of using ./tests/run.sh to pull and start the docker container for trezor-user-env, I'm using GitHub Actions / Containerized Services, and pulling the container from GitHub instead of GitLab.
  • ./tests/run.sh is still used to ensure that the container has finished starting.
• For testing, I've also reverted @trezor/rollout to be versions: "~1.2.0 || ^1.3.2", so that Node v12 CI still works.

Potentially fixes https://github.com/trezor/trezor-suite/issues/5111 (Karma tests and yarn build are only run on Node v12) (apologies for stealing something on your todo list, I had already almost completed this before I noticed you already had an issue for it!)

[mroz22]

Hi, this contribution looks really nice. I need to get familiar with this approach a bit. Also sorry for not merging #1050 yet. It does not have that high priority at the moment, since we are going to move this project into trezor-sutie repository soon and all of this CI configuration will need some more engineering.

Also I would like to invite @vdovhanych to this.

[aloisklink]

I've upgraded the build and karma tests to use ubuntu-latest in https://github.com/trezor/connect/pull/1076/commits/86c0e578ca1989a857504638c1c5244f32cf0817, and it seems to work.

Also, there was a bug where the eth/btc/... tests were testing all the methods, which I've fixed in https://github.com/trezor/connect/pull/1076/commits/0123b020f7153226d2206a3fa26633b3bf3f5e9d (my fault, I had fixed this on my testing branch, but I think the git rebase/merge didn't apply it to this branch.

Also sorry for not merging https://github.com/trezor/connect/pull/1050 yet. It does not have that high priority at the moment, since we are going to move this project into trezor-sutie repository soon and all of this CI configuration will need some more engineering.

No worries :smile: CI changes are generally less important than other PRs!

[mroz22]

Hello, I think we are ready for merge. Just please squash fixups and rebase.