search

trezor / connect

:link: A platform for easy integration of Trezor into 3rd party services
Other
349 stars 262 forks source link

Komodo coin support and outdated lib bitcoinjs-lib-zcash #396

Closed smdmitry closed 4 years ago

smdmitry commented 5 years ago

I want to integrate Komodo coin support to Connect, but Trezor Connect uses deprecated library bitcoinjs-lib-zcash here https://github.com/trezor/connect/blob/develop/src/js/backend/BlockBook.js#L8

How can this be resolved? Please look at my PR: https://github.com/karel-3d/bitcoinjs-lib/pull/13

Maybe its better use newer version of this lib supported by Trezor: https://github.com/trezor/trezor-utxo-lib/?

szymonlesisz commented 5 years ago

Hi @smdmitry I've already added Komodo to https://github.com/trezor/trezor-utxo-lib/tree/trezor/src, rewrote connect to implement this new library in branch v8-beta (this one replaces bitcoinjs-lib) BUT during tests and implementation we decided that we need to split connect repository to monorepo structure to properly add nodejs, react-native and electron support.

That's why i need to to ask you to be patient. New version of connect should be done by the end of the moth,

I will let you know here,

keraf commented 4 years ago

Komodo support has been added. Closing issue for now. Feel free to open new issues if you encounter issues using this coin with trezor-connect.