search

trezor / connect

:link: A platform for easy integration of Trezor into 3rd party services
Other
349 stars 262 forks source link

Add support for EOS REX #443

Closed danra closed 5 years ago

danra commented 5 years ago

REX support is missing when connected to bloks.io with Trezor One. From what I understood talking with bloks.io, to support this, Trezor Connect has to add support for the operation (or more in general, to non-standard EOS contracts).

Thanks, Dan

szymonlesisz commented 5 years ago

Hi @danra, not quite. Connect is just a API which provides UI for the user and provide communication with Trezor device. Adding new operation to connect doesn't solve anything. From what i know connect supports all types of operations known by the device. Here's a complete list of known operations. To support new type of operation you need to add it to the firmware in the first place. Here's how to do that

danra commented 5 years ago

I see - I will try and open a matching issue for the Trezor Wallet, then.

Thanks, Dan

On Fri, Aug 23, 2019 at 11:05 AM Szymon Lesisz notifications@github.com wrote:

Hi @danra https://github.com/danra, not quite. Connect is just a API which provides UI for the user and provide communication with Trezor device. Adding new operation to connect doesn't solve anything. From what i know connect supports all types of operations known by the device. Here's https://github.com/trezor/trezor-firmware/blob/master/common/protob/messages-eos.proto#L68-L82 a complete list of known operations. To support new type of operation you need to add it to the firmware in the first place. Here's how to do that https://wiki.trezor.io/Developers_guide-Contributing

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/trezor/connect/issues/443?email_source=notifications&email_token=AAAUSFNK6KZEUFXLUQM4M5LQF6K4TA5CNFSM4IOT3ZY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD47OVXQ#issuecomment-524217054, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAUSFNHM5FNUTXIS7XC3F3QF6K4TANCNFSM4IOT3ZYQ .