search

trezor / cython-hidapi

:snake: Python wrapper for the HIDAPI
Other
285 stars 110 forks source link

Enable support for cython>=3 #159

Closed shuffle2 closed 1 year ago

shuffle2 commented 1 year ago

fixes #156

I think the main important change is just the usage of pyxdep file to point to chid.pxd instead of specifying it in the setup.py

Also fixes a few other warnings and things.

requirements.txt might need to be added back for tox? Dunno if tox supports pyproject.toml or some nicer way than duplicating the requirements between the .txt and .toml files.

README.rst should also be updated to refer to build instead of setup.py but I'm not sure how it should work with .e.g --without-libusb

prusnak commented 1 year ago

Why the switch from requirements.txt to pyproject.toml? Is this required for cython>=3 support?

shuffle2 commented 1 year ago

I think using the toml to indicate the requirements was required to silence the warning from setuptools about PEP 517. The txt isn’t necessary in either case (I think?), except for Tox, which I only realized afterwards.