search

trezor / definitions

1 stars 5 forks source link

Coins details new info #13

Closed grdddj closed 1 year ago

grdddj commented 1 year ago

Fixes https://github.com/trezor/definitions/issues/9 Fixes https://github.com/trezor/definitions/issues/10

New fields and info into coins_details.json

matejcik commented 1 year ago

please convert network to an object with key (current value) and name (taken from the parent network) set network: null if it's not a token

explicitly set network={ bitcoin info here } for USDT(OMNI) and MaidSafeCoin (can we tell whether a thing is an Omni chain?)

change t1_enabled and t2_enabled to "support": {"T1B1": <bool>, "T2T1": <bool>, "T2B1": <same value as T2T1 for now>}

grdddj commented 1 year ago

please convert network to an object with key (current value) and name (taken from the parent network) set network: null if it's not a token

Done in 174715d

explicitly set network={ bitcoin info here } for USDT(OMNI) and MaidSafeCoin (can we tell whether a thing is an Omni chain?)

Not sure what/how to do this. Can you please give an example result how it should look like?

change t1_enabled and t2_enabled to "support": {"T1B1": <bool>, "T2T1": <bool>, "T2B1": <same value as T2T1 for now>}

Done in 174715d

Hannsek commented 1 year ago

We can adjust it here properly right now. See https://github.com/trezor/trezor-firmware/issues/2793

matejcik commented 1 year ago

We can adjust it here properly right now. See trezor/trezor-firmware#2793

i would prefer to first implement that issue in firmware repo and only afterwards start using the resulting data here.

explicitly set network={ bitcoin info here } for USDT(OMNI) and MaidSafeCoin (can we tell whether a thing is an Omni chain?)

Not sure what/how to do this. Can you please give an example result how it should look like?

"misc:USDT": {
   ...
   "network": { "key": "bitcoin:BTC", "name": "Bitcoin" }
}

dtto for MAID

grdddj commented 1 year ago

explicitly set network={ bitcoin info here } for USDT(OMNI) and MaidSafeCoin (can we tell whether a thing is an Omni chain?)

Not sure what/how to do this. Can you please give an example result how it should look like?

"misc:USDT": {
   ...
   "network": { "key": "bitcoin:BTC", "name": "Bitcoin" }
}

dtto for MAID

Thanks for the hint, done in 633ddab

matejcik commented 1 year ago

ah, there's still the override file, that's nice .)