search

trezor / python-mnemonic

:snake: Mnemonic code for generating deterministic keys, BIP39
https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki
MIT License
836 stars 365 forks source link

Require explicit Optional in type annotations #79

Closed hukkin closed 3 years ago

hukkin commented 3 years ago

This PR disables the "implicit optional" mypy feature. Type annotations relying on it are no longer PEP 484 compliant (see https://github.com/python/peps/pull/689). Mypy will also turn the feature off in a future release (see https://github.com/python/mypy/issues/9091).

matejcik commented 3 years ago

:crying_cat_face:

hukkin commented 3 years ago

@matejcik Would it be possible to make a PyPI release? Would be cool to have all the annotations brought out :smile_cat:

matejcik commented 3 years ago

this is now out on pypi