trezor / python-mnemonic

:snake: Mnemonic code for generating deterministic keys, BIP39
https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki
MIT License
843 stars 372 forks source link

Detect language unambiguously, or raise explanatory exception #99

Closed pjkundert closed 2 years ago

pjkundert commented 2 years ago

Correctly and unambiguously determine Mnemonic language.

@prusnak, perhaps this is sufficiently clear that it doesn't make the reference implementation less tidy?

prusnak commented 2 years ago

Concept ACK

@matejcik What do you think about the approach?

matejcik commented 2 years ago

concept ACK but please fix the style check

pjkundert commented 2 years ago

OK, @matejcik, I've fixed the style_check issues (the remaining failures are unrelated to this pull)

matejcik commented 2 years ago

the style check is still failing for the test file

matejcik commented 2 years ago

ah but it's something that was in the repo already. I'll fix that.