search

trezor / python-shamir-mnemonic

MIT License
165 stars 59 forks source link

Use `python3 -m pip` instead of `pip`. #22

Closed infokiller closed 4 years ago

infokiller commented 4 years ago

Fixes #20.

matejcik commented 4 years ago

it really doesn't though? the problem is not the pip invocation but the address

infokiller commented 4 years ago

Damn, you're right. Anyway, as an FYI, the correct way to invoke pip is with python -m pip, since pip3 is not always available. So I think this PR should be merge anyway, what do you think?

matejcik commented 4 years ago

can you think of a practical situation where (1) python3 is available, and (2) pip3 is not available, but (3) python3 -m pip works anyway, and (4) person using this system doesn't know enough about pip to self-correct the command?

matejcik commented 4 years ago

i mean, on Windows for example, in the default installation, neither python3 nor pip3 is available, but both python and pip are. So we'd have to drop the "3" ... but that breaks on the majority of currently existing Linux installations because it invokes python2.

infokiller commented 4 years ago

I can't think of any, though I remember I did run into an issue with pip3 being unavailable in one of my projects.