trezor / python-shamir-mnemonic

MIT License
165 stars 59 forks source link

Use secrets module instead of os.urandom. #24

Closed infokiller closed 4 years ago

infokiller commented 4 years ago

Although both of them are using the same implementation as of python 3.8 [1], the python docs recommend using the secrets module for generating secrets, and its usage makes it clearer for reviewers that a cryptographically strong source of randomness is used.

[1] https://docs.python.org/3/library/random.html#random.SystemRandom

matejcik commented 4 years ago

merged, thanks