Only recover once when passphrase is given.

trezor / python-shamir-mnemonic

MIT License

165 stars 59 forks source link

Closed infokiller closed 4 years ago

infokiller commented 4 years ago

Also wait till trying to use the passphrase before echoing success to the user.

matejcik commented 4 years ago

what is the purpose of this change?

infokiller commented 4 years ago

Mainly code simplification/cleanup. Specifically:

When there's a passphrase in the recovery, don't print "SUCCESS" before actually trying to recover with the passphrase. Also, do the recovery only once with the given passphrase, instead of also doing it without the passphrase first.
Minimize the scope of the "try" block to the actual statements that can raise the exception

matejcik commented 4 years ago

ah, I understand now. this is reasonable, thanks.