search

trezor / python-shamir-mnemonic

MIT License
165 stars 59 forks source link

Print master secret on 'create' #6

Closed slush0 closed 5 years ago

slush0 commented 5 years ago

After calling shamir create 2of3, master secret is not printed out to the console. It would be useful for checking that recovery produced the same secret.

matejcik commented 5 years ago

you can explicitly choose your master secret with the -S option i'll add an option to print the generated one as well

slush0 commented 5 years ago

Is there a need for yet another option? What's wrong on printing out the secret directly? Considering that you already have to use it on trusted computer if you really want to use that secret, and shares are printed on the display automatically. I would rather to keep stuff simple than adding options.

matejcik commented 5 years ago

eh, you're right, i'm doing it unconditionally now