added Tezos support - Githubissues

trezor / python-trezor

:snake: Don't use this repo, use the new monorepo instead:

https://github.com/trezor/trezor-firmware

GNU Lesser General Public License v3.0

201 stars 194 forks source link

Closed Adman closed 6 years ago

Adman commented 6 years ago

We also pushed signed operations to betanet network and they got accepted. Here's the list of them

matejcik commented 6 years ago

I reviewed your code, please see and make changes where appropriate.

General notes:

you should use CurveType constants in most places - maybe not in the dicts that are inputs to create_sign_tx_msg, because these might come from outside? But definitely in arguments to calls.
please mark all your tests as @pytest.mark.xfail, so that we can merge this before trezor-core code is ready

I also did a big change to master, so now you get merge conflicts. Resolution instructions are as follows:

fix trezorctl. that should be as simple as copy-pasting your code pre-merge to the appropriate place post-merge
change @field-@expect decorators to @expect(..., field=...)
run make style. this requires Python 3.6

You should also be able to leverage protobuf.dict_to_proto instead of the explicit create_sign_tx_msg function.

Adman commented 6 years ago

@matejcik Everything should be fixed

matejcik commented 6 years ago

thank you. Looks mostly good now, a couple minor points. I'll also wait for changes in the used paths (or not), as discussed on Gitter.

Adman commented 6 years ago

@matejcik I will rework this to support only one curve ed25519.

Adman commented 6 years ago

@matejcik done. Tests:

matejcik commented 6 years ago

Looks good. Please add @pytest.mark.skip_t1 to all tests, we won't be doing Tezos on T1 codebase. I'm ready to merge after that change.

Adman commented 6 years ago

Added

matejcik commented 6 years ago

Thanks!