search

trezor / python-trezor

:snake: Don't use this repo, use the new monorepo instead:
https://github.com/trezor/trezor-firmware
GNU Lesser General Public License v3.0
201 stars 194 forks source link

Add coverage for cardano signTx with change address #329

Closed ddeath closed 5 years ago

ddeath commented 5 years ago

In current test there is not covered option when transaction has change address.

This PR adding coverage for that.

Fixing https://github.com/trezor/trezor-core/issues/382

prusnak commented 5 years ago

I would rather have two distinct test fixtures instead of replacing the old one with the new one.

Can you add a new fixture instead of modifying the old one?

matejcik commented 5 years ago

while you're at it, maybe take a look at https://github.com/trezor/python-trezor/blob/1397c3b4d9e6c95e44a0e6460d02b817f73e8492/trezorlib/tests/device_tests/test_msg_resetdevice_t2.py#L37 ?

ddeath commented 5 years ago

I made a separate fixture. Tried to put it into input_flow() but it was not working so didnt changed it for now.

matejcik commented 5 years ago

I refactored your original test in the meantime - apparently the swipe-down is not needed anymore?

Please look at the new version and check if it can work with your new test.

matejcik commented 5 years ago

superseded by #342