trezor / python-trezor

:snake: Don't use this repo, use the new monorepo instead:
https://github.com/trezor/trezor-firmware
GNU Lesser General Public License v3.0
201 stars 194 forks source link

Add Eos support #336

Closed atkachyshyn closed 5 years ago

prusnak commented 5 years ago

Depends on https://github.com/trezor/trezor-common/pull/231

matejcik commented 5 years ago

why is there a truckload of JSON files in a new misc directory?

atkachyshyn commented 5 years ago

Its the examples of the all possible transactions to be signed, so anybody can check them right away. Should i remove them or probably move to some other place?

ср, 7 лист. 2018 о 14:42 matejcik notifications@github.com пише:

why is there a truckload of JSON files in a new misc directory?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/trezor/python-trezor/pull/336#issuecomment-436610458, or mute the thread https://github.com/notifications/unsubscribe-auth/AGzlc3BH006c2tAHxroXXnExPd9za-Z6ks5ustUYgaJpZM4YRByu .

matejcik commented 5 years ago

You could turn them into test cases. That's missing from your submission anyway. In that case they should move into trezorlib/tests/device_tests/eos or something like that.

atkachyshyn commented 5 years ago

OK, thanks for the suggestion. Will do that.

ср, 7 лист. 2018 о 15:03 matejcik notifications@github.com пише:

You could turn them into test cases. That's missing from your submission anyway. In that case they should move into trezorlib/tests/device_tests/eos or something like that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/trezor/python-trezor/pull/336#issuecomment-436615815, or mute the thread https://github.com/notifications/unsubscribe-auth/AGzlc8s_jsHZ0G_lDezZL3EfjaXzjXVHks5ustomgaJpZM4YRByu .

matejcik commented 5 years ago

closing for cleanup now. please apply your changes to the monorepo at https://github.com/trezor/trezor-firmware, together with the corresponding trezor-core PR, and resubmit.

also please update your python-trezor code to match the current implementation, esp. the testcases.

please make use of trezorlib.protobuf.dict_to_proto where appropriate, instead of having explicit converters for the json fields.