search

trezor / python-trezor

:snake: Don't use this repo, use the new monorepo instead:
https://github.com/trezor/trezor-firmware
GNU Lesser General Public License v3.0
201 stars 194 forks source link

blockbook missing locktime #344

Closed brianddk closed 5 years ago

brianddk commented 5 years ago

blockbook doesn't seem to always return locktime which breaks PAYTOADDRESS in versions < 0.11. Defaulting to zero for cross-compatibility with existing blockbook servers.

BTW, this fires from trezorctl sign-tx if that wasn't clear.

matejcik commented 5 years ago

This is fixed in 0.11 which was just released.

Users of trezorctl should upgrade to 0.11 and I'm not aware of other applications that would require 0.10.x and rely on the built-in TxApi, so I'm going to close this.

brianddk commented 5 years ago

I'm not aware of other applications that would require 0.10.x

I believe that Electrum 3.2.3 still requires 0.10.x (ie its not forward compatible). Other conflicts prevent me from testing Electrum@master but I might later. Plus all the Electrum forks (BCH, LTC, FTC.. etc) are quite a few commits behind Electrum@master so they are even deeper in the hole.

I've patched my install since I'm not really using locktime or LN in any of my TXNs presently.

matejcik commented 5 years ago

There's https://github.com/spesmilo/electrum/pull/4875 which is likely to end up in Electrum 3.3 - I'm told that's going to be out in a week or two.

brianddk commented 5 years ago

There's spesmilo/electrum#4875 which is likely to end up in Electrum 3.3 - I'm told that's going to be out in a week or two.

Thx... Looks to be in master @ https://github.com/spesmilo/electrum/commit/c33c90733008fd8f88a374dfe9098dad9c50b6c9#diff-d340122daff15ed7703f584dd191bc92

I just need to work on getting Electrum@master building on Unbuntu 16.04 (personal problem ;)