Closed SomberNight closed 5 years ago
Seems legit; @matejcik what do you think? Please merge if you are OK with the change.
Is it worth pushing a new release to PyPI so it's easier for Electrum to pull in the change? I vote for yes because that also applies the fix in https://github.com/trezor/python-trezor/commit/cf9106ff5d7be28cc3b75dccef7bef6ba37fbe1e
agreed, I'll merge & release tomorrow
I have merged this. I'm holding off on releasing because a Travis build got broken and while I don't think it's related, better safe than sorry.
travis problem is resolved, release is tagged and published to PyPI thank you all and have a nice end of year .)
Thank you for the prompt response
Apparently,
import PyQt5.Qt
imports "all of Qt". Let's not do this please. :)see https://github.com/spesmilo/electrum/issues/4960