search

trezor / python-trezor

:snake: Don't use this repo, use the new monorepo instead:
https://github.com/trezor/trezor-firmware
GNU Lesser General Public License v3.0
201 stars 194 forks source link

Add get public key to Ethereum #353

Closed tsusanka closed 5 years ago

tsusanka commented 5 years ago

Since this functionality is not yet implemented in trezor-core we should probably wait. Tracked in https://github.com/trezor/trezor-core/issues/406

matejcik commented 5 years ago

does trezor-mcu have it?

tsusanka commented 5 years ago

It does not, I'm sorry I keep forgetting about mcu.

What is the correct approach to this? Do we have a tag or smth like that to denote something is missing on T1?

I could implement this on trezor-mcu, but I'm not sure it is worth it, since we plan to deprecate it. In the meanwhile the frontend can use the Bitcoin's get public key as it does currently.

matejcik commented 5 years ago

that's probably more up to wallet devs to decide; this way they'll have a non-uniform interface

anyway, you'd have to mark the test as @pytest.mark.skip_t1

tsusanka commented 5 years ago

Agreed to be implemented. PR in https://github.com/trezor/trezor-mcu/pull/447 . So this should wait for it I guess

prusnak commented 5 years ago

Just merged into trezor-mcu, let's merge this one as well, I guess

matejcik commented 5 years ago

merged, thanks

matejcik commented 5 years ago

ah darn, should've waited for the trezor-core PR. oh well.