Closed AlexITC closed 5 years ago
Travis fixed.
explorer-related code should not be in python-trezor at all, its presence is a historical vestige. I'm going to remove it in a matter of months, so there's no point in improving it.
Maybe your code will be useful for microwallet, a new project that's supposed to take over this part of trezorctl's responsibilities. But the problem is that we don't really want to be stuck maintaining a bunch of different explorer APIs. I'll try to figure out some sort of plugin architecture, possibly based on setuptools entry points, so that it could be extended outside the base distribution.
Now, the
custom_explorer
field could be added to the json files, for example:Then, the api class is loaded dynamically, which allows to decouple from the blockbook explorer.
There are some possible improvements:
tx_api.py
to theexplorers
module.The goal of this PR is to discuss a bit about what do you guys expect and make the necessary changes after that.
Thanks.