search

trezor / python-trezor

:snake: Don't use this repo, use the new monorepo instead:
https://github.com/trezor/trezor-firmware
GNU Lesser General Public License v3.0
201 stars 194 forks source link

Fix trezorctl for protobuf changes in 0.11.2 #365

Closed brianddk closed 5 years ago

brianddk commented 5 years ago

NOTE: This change will break backward compatibility for older FW with these commands.

matejcik commented 5 years ago

thanks maybe we should bump the minimum required firmware then, to 1.8.0 and 2.1.0. care to add that to the PR? the values are in trezorlib/__init__.py.

we probably won't be releasing a new version soon, and when it gets released, the up-to-date versions are hopefully going to be widespread enough

brianddk commented 5 years ago

thanks maybe we should bump the minimum required firmware then, to 1.8.0 and 2.1.0. care to add that to the PR? the values are in trezorlib/__init__.py.

Sure. Since I didn't know your release schedule, I didn't initially bump the minimum version. I'll bump it, but also wanted to check to other protobuf changes. There were a few other messages I didn't get around to validating.

I'll try to work them in as well.

brianddk commented 5 years ago

@matejcik is there any way to downgrade the bootloader and FW from 1.8.0? I wanted to go back to 1.7.3 or earlier to verify the MINIMUM_FIRMWARE_VERSION settings side effects, but now, unfortunately, I'm locked in at 1.8.0 on both devices.

matejcik commented 5 years ago

that's not possible. probably the easiest way to verify the effect is bump up the min version to 1.8.1 though

matejcik commented 5 years ago

i'm now working on ethereum subcommands, so i'm merging this now.

thanks for your work!

btw, the backwards compatibility was already broken with the protobuf update, so the changes in trezorctl do nothing worse