Add Groestlcoin device tests

trezor / python-trezor

:snake: Don't use this repo, use the new monorepo instead:

https://github.com/trezor/trezor-firmware

GNU Lesser General Public License v3.0

201 stars 194 forks source link

Add Groestlcoin device tests #368

Closed yura-pakhuchiy closed 5 years ago

yura-pakhuchiy commented 5 years ago

Bitcoin tests do not fully cover Groestlcoin because GRS uses some hashes differently from Bitcoin and changes to other coins may accidentally break GRS. Based on GRS tests in T2 repo.

yura-pakhuchiy commented 5 years ago

@matejcik Thank you for the review! I've pushed update.

matejcik commented 5 years ago

looking good. just to make sure, do these tests pass with current T1 and TT master?

yura-pakhuchiy commented 5 years ago

I've tested against trezor-core 8be4ed41bc7f3ad841166a731817b68f302d8a50 and mcu 964a622bb512aa85cfcc3e451fc70729cc15bb4f. They should pass master unless few more recent commits broke something.

matejcik commented 5 years ago

alright, merged, thanks :+1: