search

trezor / trezor-common

:lock: Don't post issues/PRs to here, use the new monorepo:
https://github.com/trezor/trezor-firmware
GNU Lesser General Public License v3.0
91 stars 232 forks source link

Add Musicoin support #182

Closed mkrufky closed 6 years ago

mkrufky commented 6 years ago

homepage : https://musicoin.org block explorer : https://explorer.musicoin.org slip0044 index : 184 chainId : 7762959

depends-on: https://github.com/trezor/trezor-mcu/pull/388

prusnak commented 6 years ago

Can you please point me to the documentation where Musiccoin claims it is using EIP-155 replay protection and they use chainId = 7762959?

mkrufky commented 6 years ago

Musicoin has been unable to work with hardware wallets until the following PR was merged recently: https://github.com/trezor/trezor-mcu/pull/381

The Musicoin network has had EIP-155 Replay attack protection enabled on their network ever since the following PR got merged in February: https://github.com/Musicoin/go-musicoin/pull/62

Observe the Chain ID of 7762959 in the same PR, here: https://github.com/Musicoin/go-musicoin/pull/62/files#diff-a894bbf771e5541f902b5b16f367f99dL37

Some additional links showing Musicoin's Chain ID of 7762959:

Bitcointalk: https://bitcointalk.org/index.php?topic=1776113.0

Steemit - Musicoin Specification: https://steemit.com/bitcoin/@animelovers/musicoin-altcoin-nuanced-music-2017712t164413659z

StackExchange: https://ethereum.stackexchange.com/questions/17051/how-to-select-a-network-id-or-is-there-a-list-of-network-ids

matejcik commented 6 years ago

@mkrufky your trezor-common PR claims that the shortcut is MUSIC, yet your trezor-mcu PR uses MUSI suffix. Which is it?