search

trezor / trezor-common

:lock: Don't post issues/PRs to here, use the new monorepo:
https://github.com/trezor/trezor-firmware
GNU Lesser General Public License v3.0
91 stars 232 forks source link

Add Ontology support #184

Closed backslash47 closed 6 years ago

backslash47 commented 6 years ago

Hi,

I prepared protobuff messages for Ontology support. Currently there are 5 methods defined: getPublicKey, getAddress, signTx, signTransfer and signWithdrawOng

This will provide support for all necessary wallet functionality.

backslash47 commented 6 years ago

Hello, I don't want to be rude, but is there a timeframe for reviewing this PR?

prusnak commented 6 years ago

End of next week. I am on a sick leave at the moment.

backslash47 commented 6 years ago

@prusnak Thanks for the response. Hope you get well soon.

backslash47 commented 6 years ago

Hello, I fixed the typo, added missing messages, fixed attribute indexes, unified naming convention and removed arbitrary transaction sign.

I also fixed the tags @start and @end, but I am not sure if I've done it correctly.

Please have a look.

prusnak commented 6 years ago

LGTM Thanks!