XMR: protob protocol improvements

trezor / trezor-common

:lock: Don't post issues/PRs to here, use the new monorepo:

https://github.com/trezor/trezor-firmware

GNU Lesser General Public License v3.0

91 stars 232 forks source link

XMR: protob protocol improvements #192

Closed ph4r05 closed 6 years ago

ph4r05 commented 6 years ago

Uses only protobuff messages for the transaction construction data - forward compatible. Original transaction source entry and related messages are not stable on Monero side, serialization format of the cryptonote serialization could be changed in the future (new fields), CN serialization does not support versioning, thus it is not forward compatible.
MoneroTransactionDestinationEntry, MoneroTransactionSourceEntry have to be defined in the root level as they are used in various protocol messages

prusnak commented 6 years ago

LGTM!

It seems there are two more structures represented as bytes: xmrtypes.TxinToKey and xmrtypes.TxOut. Are we OK with that?

ph4r05 commented 6 years ago

Thanks for the review!

Ad xmrtypes.TxinToKey and xmrtypes.TxOut - those are fine as they are directly part of the transaction that goes to the block chain, the format is not going to change for a while and if yes we need also some more refactoring on different places so I would keep it like it is.