search

trezor / trezor-common

:lock: Don't post issues/PRs to here, use the new monorepo:
https://github.com/trezor/trezor-firmware
GNU Lesser General Public License v3.0
91 stars 232 forks source link

Added BitCash #232

Closed ghost closed 5 years ago

ghost commented 5 years ago

Add support for BitCash

prusnak commented 5 years ago

Fix build failure - there are couple of tests failing.

Another note: this coin will never be accepted into Trezor in its current form as it uses the same address format as Bitcoin. If you want this supported on Trezor, approach the coin developers to change the address version.

ghost commented 5 years ago

I am the developer of BitCash. BitCash indeed uses the 0 as version byte for the addresses. But the address itself is much longer than a Bitcoin address. For example, this is a valid BitCash address: 17YoNDb7fEpNkkgQ8HaxgFVAoMoEnimPxiV5qmmvtLWjKWbkL7B Is this a problem? How can I reproduce the build failure? Do you have any hints for me?

matejcik commented 5 years ago

run python3 tools/cointool.py check

this will show you checks that have failed.

ghost commented 5 years ago

Okay, I made some changes. Now the tests shows no error any longer. I will add the support for the new prefix byte for the addresses to the BitCash wallet.

prusnak commented 5 years ago

Remove check.sh file you created. Remove backend URL, this is not a valid bitcore backend.

ghost commented 5 years ago

Okay, I removed the file and the URL now.