Closed TheSin- closed 5 years ago
prusnak
commented
5 years ago TRC contact changed in 8d7dd590ffe8c02a8d09aaefb7af41c11503f5a2
As I've said earlier, change the address version so it does not collide with Bitcoin and we might consider adding TRC to Trezor. You don't need to do the same thing like BCH does, if you change the address version to something else (so addresses does not start with 1), it should be enough.
TheSin-
commented
5 years ago Thanks for the change, I appreciate it.
Changing 6 years of chain data isn't that easy, likely why BCH did what they did. So the only solution available is to change 6 years of history and all of our current users? There is nothing else that can be done or discussed? A change like this would affect our 1000+ Masternode network, it would require a massive infrastructure overhaul and it would all basically have to happen over night, basically a HF which exchanges don't even support so then we'd have to re apply to all exchanges, etc etc. I really really do not want to leave Trezor support out hence why I'm so adamant here but I'm just not sure changing 6 years of data is an acceptable solution here.
prusnak
commented
5 years ago You don't have to change any of the blockchain data. If you change address version, only the presentation of the data will change. I know this is a big change, maybe bigger your coin developers can handle, but it was a bad decision not to change address version at the beginning.
TheSin-
commented
5 years ago I don't disagree but at the time there was only 16 coins in existence, I'm not sure if any of them knew back then that it wasn't a great idea.
I understand I can't change the chain data, that would be a disaster, but I do need to reset all the current addresses using the same private key to the new address, but that is still a MASSIVE change, not for the devel team (which is me), but to the entire community and infrastructure.
The worst being that exchanges like cryptopia don't support HFs anymore, and I can not see an easy way to Soft Fork this type of change easily. I guess my only option is to consider it, but this will take a considerable amount of time to change and likely a multiple release setup to do it, and all for only 1 HW (sadly my personal favourite), I haven't had any push back from others.
Obviously vanity addresses are the ones that suffer the most, and some of our clients like have one address for BTC and TRC.
Guess more internal discussion needs to happen, I just wanted to be 100% certain it was the only option. Thanks for the consideration no matter what we decide.
prusnak
commented
5 years ago We have to rethink this. Maybe it would be possible to enable TRC on Trezor if we made coin name more visible in the device UI. Which is planned in the future, but no ETA yet.
TheSin-
commented
5 years ago well this is encouraging, I mean it would likely take us the better part of a year to get the address change rolled out so if there is a possibility even if it takes time it's worth investigating.
If there is something I can do to help, Testing, PRs, etc (free labour) :P
https://github.com/trezor/trezor-common/blob/8c53177626349e801757b0a1452a50ed72c51f27/defs/bitcoin/terracoin.json#L7
Could this be changed to
"The Terracoin Foundation <support@terracoin.io>"Also I made a comment on https://github.com/trezor/trezor-common/pull/75 but since I can't reopen it I told a new ticket pointing it out would help?
This is the Quote from it...
Hi @prusnak I have been told that we have run into an issue here. I guess because we share addressing with bitcoin this isn't do able? We are 6 years old so changing our addressing isn't really something we are interested in, what are our other options to be supported by your project? Do I have to look at a masking like bch? I mean I'm not really keen on that either, but I'm just trying to make things work as I'd really like to get Trezor support with Terracoin. Please let me know your thought or anything I can do to make this possible.