search

trezor / trezor-common

:lock: Don't post issues/PRs to here, use the new monorepo:
https://github.com/trezor/trezor-firmware
GNU Lesser General Public License v3.0
91 stars 232 forks source link

[req] Allow use of other git services #262

Closed baff5b closed 5 years ago

baff5b commented 5 years ago

Hello,

Is it possible to use other Git services, like GitLab, when referencing the location for a coin's node source in a definition file? When initially testing, I saw that it would not validate : 

github: Value does not match regex ^https://github.com/.*[^/]$

when I used a gitlab link. It is possible to mirror the repository to GitHub, but I wanted to know if the repository can be referenced directly.

matejcik commented 5 years ago

that shouldn't be a problem, please send a PR with your gitlab value, I'll update the check

prusnak commented 5 years ago

Should work now