Cardano sign/verify does not have tests

trezor / trezor-core

:lock: Don't use this repo, use the new monorepo instead:

https://github.com/trezor/trezor-firmware

GNU General Public License v3.0

353 stars 204 forks source link

Cardano sign/verify does not have tests #492

Closed tsusanka closed 5 years ago

tsusanka commented 5 years ago

It looks like Cardano does not have tests for sign/verify functions. @ddeath do you actaully use this functionality in Adalite? Or anywhere else?

refi93 commented 5 years ago

@tsusanka we don't use in AdaLite signing/verifying of arbitrary messages, only transactions

tsusanka commented 5 years ago

@prusnak let's remove it? I think it's the same case as before for other coins. The sign/verify functions were added mostly because other coins had it. But if it has no direct usage for the coin.. We can return it easily if needed

Oh, it doesn't have protobuf messages currently anyway.

tsusanka commented 5 years ago

ACKed by stick