search

trezor / trezor-firmware

:lock: Trezor Firmware Monorepo
https://trezor.io
Other
1.36k stars 663 forks source link

make API support more granular in trezorlib #1062

Open fresheneesz opened 4 years ago

fresheneesz commented 4 years ago

Is your feature request related to a problem? Please describe. Electrum has a scary warning message that comes up if your trezor firmware is below the version the library supports.

Describe the solution you'd like Two possibilities:

  1. Increase the length of time firmware versions are support to 2 years (from what looks like 1 year).
  2. Provide the ability to check firmware version requirements in a more granular way (eg at the API command level) so that software like Electrum can inform the user more specifically which features will work correctly and which are likely not to work.

Describe alternatives you've considered Described above.

prusnak commented 4 years ago

We did not break API for 5 years, but recently there were very good reasons to go ahead and break it. Thanks for the suggestion.

matejcik commented 4 years ago

I'm going to reopen this and keep it in the backlog. Having trezorlib calls granular by the newest supported version (via decorators, probably) would be rather nice, even if only for code documentation purposes.