search

trezor / trezor-firmware

:lock: Trezor Firmware Monorepo
https://trezor.io
Other
1.36k stars 663 forks source link

Stellar: add support for AMMs related operations. #1833

Open overcat opened 3 years ago

overcat commented 3 years ago

Is your feature request related to a problem? Please describe.

SDF plans to add support for AMMs to Stellar Protocol 18, which will be deployed to the test network today. I personally believe that AMMs related features are important for the users and that these operations will be used with high frequency.

I know you are very busy with Trezor Suit related work right now, I would love to submit a PR to implement these features, would you be able to dedicate resources to review it?

If you have any questions, please let me know, thank you.

Describe the solution you'd like

See: https://github.com/stellar/stellar-protocol/blob/master/core/cap-0038.md#xdr-changes

Describe alternatives you've considered none

Additional context

matejcik commented 3 years ago

For now, we will not be accepting this addition to Stellar. I'm leaving the issue open for now, for if/when the situation changes.

overcat commented 1 year ago

For now, we will not be accepting this addition to Stellar. I'm leaving the issue open for now, for if/when the situation changes.

Hi @matejcik, I would like to ask if this status has changed and if you still do not accept the addition of new features.

P.S. Stellar is currently ranked 22 on coinmarketcap.

matejcik commented 11 months ago

Hello @overcat, the status has indeed changed. Feel free to go ahead with the PR and feel free to open issues for other missing Stellar features.

overcat commented 11 months ago

Hi @matejcik, thank you for your reply, I have already placed it on my schedule.