UI2: wrong confirm total flow for altcoins

trezor / trezor-firmware

:lock: Trezor Firmware Monorepo

https://trezor.io

Other

1.36k stars 661 forks source link

UI2: wrong confirm total flow for altcoins #2712

Open matejcik opened 1 year ago

matejcik commented 1 year ago

https://satoshilabs.gitlab.io/-/trezor/trezor-firmware/-/jobs/3549968773/artifacts/test_ui_report/passed/TT_ripple-test_sign_tx.py::test_ripple_sign_simple_tx.html

Ripple first shows fee, then destination, then amount. Final "hold to confirm" is missing.

To align with the other flows, we should show destination -> amount -> fee -> total (hold to confirm)

matejcik commented 1 year ago

let's keep this open for the separate purpose of "make altcoin flows align with Bitcoin", i.e., make sure the last screen is always something like "hold to confirm total", that the fees are in front, etc.