Use the same mnemonic dialog for BIP-39 as for SLIP-39

trezor / trezor-firmware

:lock: Trezor Firmware Monorepo

https://trezor.io

Other

1.35k stars 652 forks source link

Use the same mnemonic dialog for BIP-39 as for SLIP-39 #409

Closed tsusanka closed 5 years ago

tsusanka commented 5 years ago

The UI when showing mnemonic words is now different for BIP-39 and SLIP-39. Let's merge it into one (the SLIP-39 one).

BIP: emu00000000 emu00000001

SLIP: shamiremu00000000 shamiremu00000001

ciny commented 5 years ago

While unifying the layouts I found that when confirming the displayed share words bip39 sends ButtonRequest.ResetDevice while slip39 sends ButtonRequest.Other. Unified to ResetDevice since it makes more sense in this context.

ciny commented 5 years ago

Fixed, will be part of PR for #456

ciny commented 5 years ago

implemented in #484