search

trezor / trezor-firmware

:lock: Trezor Firmware Monorepo
https://trezor.io
Other
1.34k stars 652 forks source link

Restart device after upgrading the bootloader #4168

Open matejcik opened 1 week ago

matejcik commented 1 week ago

Right now, trezor-core firmwares do not restart after upgrading the bootloader. This might be a problem in some edge cases: the firmware assumes that it's running under the "right" bootloader, but if the bootloader was just upgraded, this assumption might not be true.

Trezor One halts after the bootloader is upgraded, asking the user to reconnect.

We should probably bring the same behavior to trezor-core. To make it user-friendly, the device can restart itself instead of asking for a reconnect ... unless the software induced restart is not "full" in some sense and could cause problems for the bootloader coming up?

Hannsek commented 1 week ago

Let's please try to not force reconnecting the device 🙏🏻