Rename webauthn, u2f, etc. to "fido"

trezor / trezor-firmware

:lock: Trezor Firmware Monorepo

https://trezor.io

Other

1.33k stars 649 forks source link

Rename webauthn, u2f, etc. to "fido" #703

Open matejcik opened 4 years ago

matejcik commented 4 years ago

The functionality that was originally U2F and grew to include WebAuthN and FIDO2 is named ... inconsistently.

A good name for the whole complex is fido. This name should be used in protobuf messages, app/module names, etc.

This will be implemented in trezorlib/trezorctl. An open question is, should we rename it everywhere else too? Is it worth the hassle?

prusnak commented 4 years ago

Places where a rename can/should take place:

[ ] app name core/src/apps/webauthn -> core/src/apps/fido
[ ] protobuf message names {GetNext,Next,Set}U2FCounter -> {GetNext,Next,Set}FIDOCounter (messages-management.proto)
[ ] protobuf field names u2f_counter -> fido_counter (LoadDevice, ResetDevice, RecoveryDevice - all in messages-management.proto)
[ ] protobuf messages names WebAuthn* -> FIDO* (messages-webauthn.proto)
[ ] storage: U2F_COUNTER -> FIDO_COUNTER

matejcik commented 4 years ago

[ ] protobuf message names {GetNext,Next,Set}U2FCounter -> {GetNext,Next,Set}FIDOCounter (messages-management.proto)

[ ] protobuf messages names WebAuthn* -> FIDO* (messages-webauthn.proto)

*FIDOCounter should be all moved to messages-fido.proto too