trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
705 stars 248 forks source link

Replacing transaction wipes its label #10047

Open Hermez-cz opened 10 months ago

Hermez-cz commented 10 months ago

When replacing a transaction via Bump fee or Finalize transaction, its label is wiper if there's one already.

Suite version: 23.11.5 app (Apple Silicon) Device: T2B1 FW 2.6.3 OS: MacOS 14.1.1

How to reproduce:

  1. Go to send a transaction (I've tried Bitcoin testnet)
  2. Label the transaction in the send form or in transaction history right after approving the transaction
  3. Bump fee or finalize transaction
  4. Observe if the label is gone

Expected behavior: The label should stay the same, replacing transaction shouldn't change it in any way as for the user it's the same transaction no matter if the txid has changed.

Video:

https://github.com/trezor/trezor-suite/assets/88533514/b9fe95cc-feb7-4ef0-ba29-e08bcb3ba377

bosomt commented 8 months ago

duplicity ? https://github.com/trezor/trezor-suite/issues/7157