Empower Phosphor Icons

[dahaca]

The problem

The design system is using Phosphor icons, however the web and desktop Suite is still using the old locally stored icons. Suite mobile is using Phosphor icons however they are storing them locally as well.

I believe the best solution for Suite moving forward is to transition to the official Phosphor React library, which also allows to add custom icons, which we have as well.

The solution

Proposed flow, feel free to come up with something else:

• [ ] Add the library

  • come up with how they will be used
  • figure out where custom icons will be stored – probably the icons package?
  • make sure everything is ready for the all the uses of the existing Icon component from the components package.
  • refer to the Icon.web.tsx for streamlined examples of usage, as it was supposed to be the Icon component for web and desktop (with a similar interface as the mobile one) before I realized manually including icon files is clunky and unsustainable.

• [ ] Replace old icons

  • can be done in batches to avoid overly complex PRs
  • the goal is to have no Icon in the components package and other related files
  • also the Icon.web.tsx should be removed, unless somehow re-purposed? It's used just in a couple places, but those should all use Phosphor too.
  • currently this step is blocked by https://github.com/trezor/trezor-suite/issues/10379

• [ ] Decide the future of the icons package

  • should it be mobile-only? Should it have some universal types as it does now? hold custom icon definitions for Phosphor? 🤔
  • will mobile ever switch to phosphor native so we do not copy icons from Figma... ever again? 👀 That could unify the workflow even more and remove any possibility of visual inconsistency related to incorrect exports.
  • cc: @juriczech @PeKne @Nodonisko

[Nodonisko]

We will keep it mobile only for now, it works very well for us now and I don't see point in migrating right now. It may change in future, but for now it's just easier for us to keep things as they are.

I would suggest only moving it to suite-native domain once you will complete migration to your new solution.