trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
671 stars 242 forks source link

Design refactoring: Padding, Spacing, Radius #11921

Open shenkys opened 2 months ago

shenkys commented 2 months ago

As of now, we've got some mismatch between code & design.

So far discovered

Radius Small = 12px in design, 8px in code Radius Large = 20px in design, 24px in code

Radius used on (almost) all cards: Design = radius-lg (20px) Code = radius-md (16px)

There's definitely more to it so....

....we should dedicate a day or two with dev to:

Check for mismatching values in already existing tokens

Check for mismatching usage of these tokens (e.g. the cards) & and align on it long term

This will help us with:

vytick commented 2 months ago

I agree, that unification of design tokens and values used in the code would be beneficial in order to speak the same language. Not only in case of radius, but also other properties (spacings, paddings, ...)

Also the design and app current state is not in real sync now partially because of this.