search

trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
724 stars 251 forks source link

Connect core in popup - analytics consent before core loaded #11944

Open martykan opened 7 months ago

martykan commented 7 months ago

Describe the bug It's possible to accept analytics before core is loaded, it results in a silent error. I see this in popup E2E tests sometimes, but it doesn't seem to be causing further issues in practice.

How to reproduce

  1. To test manually, add a delay before loading core in initCoreInPopup
  2. Call any method, during loading open analytics settings in the lower right corner
  3. Press Confirm
  4. See error in console

Expected behavior Show analytics settings only after core is loaded

Screenshots

Screenshot 2024-04-09 at 15 16 13
MiroslavProchazka commented 7 months ago

@Hannsek leaving this up to your decision for setting priority