EVM Tokens/ (un)hidden tokens are not reflected in transaction history

trezor / trezor-suite

Trezor Suite Monorepo

https://trezor.io/trezor-suite

Other

678 stars 244 forks source link

EVM Tokens/ (un)hidden tokens are not reflected in transaction history #13039

Open tomasklim opened 3 weeks ago

tomasklim commented 3 weeks ago

Describe the bug When I unhide scam token, it is still marked as scam in tx history

Info:

Suite Version: develop

Expected behavior

I would expect that unhidden tokens are not marked anymore
I am not sure if I would expect that hidden tokens are now marked as "scam". Probably not
I am not able to mark/unmark tokens with balance 0 because they are hidden, I would probably like to be able to hide/unhide tokens with balance 0 so there should probably be option to show 0 balance tokens using some filter

tomasklim commented 3 weeks ago

@Hannsek

Hannsek commented 2 weeks ago

I am not able to mark/unmark tokens with balance 0 because they are hidden, I would probably like to be able to hide/unhide tokens with balance 0 so there should probably be option to show 0 balance tokens using some filter

Why would you like to do that?

I would expect that unhidden tokens are not marked anymore

Most probably yes, I am thinking about putting some warning after unhiding scammy tokens. But maybe not needed.

Seems like low prio.

tomasklim commented 2 weeks ago

if we not do it 100% now, we will never do it 😀

AdamSchinzel commented 2 weeks ago

I think this is quite important. I agree with not marking transactions with tokens that are unhidden as scammy but when I hide some token I would probably mark the transaction with this token as a scammy one. You hid it for some reason and you don't want to see it anymore.

I am not able to mark/unmark tokens with balance 0 because they are hidden, I would probably like to be able to hide/unhide tokens with balance 0 so there should probably be option to show 0 balance tokens using some filter

True but I think it's not a big problem.