Labelling issues when using multiple Trezors

trezor / trezor-suite

Trezor Suite Monorepo

https://trezor.io/trezor-suite

Other

693 stars 246 forks source link

Labelling issues when using multiple Trezors #13204

Open jvaclavik opened 2 months ago

jvaclavik commented 2 months ago

Steps to reproduce

Add first Trezor
Rename wallet (allow labelling on device)
Add second Trezor
Rename wallet (allow labelling on device)
Disable labelling in settings
Can't rename any labels

Expected behaviour

disabling device should disable renaming only for specific device, not for all of them
enable labelling should be in device settings, not in application

Hannsek commented 2 months ago

I disagree, labelling is an application feature. So if you disable labelling in Suite settings, it shouldn't be possible to do anything with the labels.

Hannsek commented 2 months ago

We can totally come up with some sophisticated setting, like disabling setting for the device when you have 2 or more connected at once. That does make sense.