Refactor safe area insets

trezor / trezor-suite

Trezor Suite Monorepo

https://trezor.io/trezor-suite

Other

695 stars 246 forks source link

Refactor safe area insets #13659

Open PeKne opened 1 month ago

PeKne commented 1 month ago

The https://www.npmjs.com/package/react-native-safe-area-contex is unnecessarily handled on multiple places at once (Screen, OfflineBanner, MessageSystemBanner etc.). It should be enough to create a top-level component that will handle it only once for all the children components mentioned.

Acceptance criteria

safe area insets are handle only in a singe top level component and nowhere else

matejkriz commented 2 weeks ago

Is it supposed to be a pure code refactoring or there is some bug that should be fixed by this?

PeKne commented 2 weeks ago

Just a code simplification.