search

trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
737 stars 255 forks source link

Signing with Trezonr One using Rabby Extension is extremely slow - 10 seconds loading #13966

Open 0xGitGuy opened 3 months ago

0xGitGuy commented 3 months ago

Describe the bug Using rabby as the Brave extension to sign with Model One takes 10 secs before (an entire eth block has passed by then) the trezor bridge page finish load and Model One displays PIN or signing message on the device. Metamask is a lot faster like 1-2secs.

Firmware version and revision Rabby 0.92.86 Brave Version 1.68.137 Chromium: 127.0.6533.100 (Official Build) (64-bit) Model One 1.12.1

Desktop/smartphone setup (please complete the following information):

To Reproduce Steps to reproduce the behavior:

  1. Use rabby to sign any Ethereum L1 transaction
  2. Trezor bridge pops up also instantly
  3. Trezor bridge page loads 4 secs+ "Initiating Core.."
  4. Then Trezor bridge page loads another 4 secs or so "Waiting for...."
  5. Only after about 10 secs from transitioning from Rabby extension to Trezor bridge page, the Model One finally wakes up and shows the PIN option or transaction message for signing. (Metamask 1-2secs?)
  6. After signing txn, the Rabby extension takes 3 secs or so to recognize before auto closing the pop up. (Metamask 1sec?)

Expected behavior Trezor bridge page loads and wakes up trezor quickly under 2secs just like for Metamask.

Screenshots Not relevant.

Additional context Rabby team says issue lies with Trezor bridge and that Metamask and Rabby uses different version of the Trezor bridge SDK.

yours truly, frustrated trezor user that keeps having issue with top wallets and their version upgrade BS

Hannsek commented 3 months ago

@evgenysl please take a look and test it. 🙏🏻

evgenysl commented 3 months ago

I do not experience any delays, see video attached.

Rabby 0.92.88 Brave Version 1.68.137 Chromium: 127.0.6533.100 (Official Build) (arm64) Model One 1.12.1

https://github.com/user-attachments/assets/82078f65-f355-420e-9e4c-d367dae238fd

0xGitGuy commented 3 months ago

@evgenysl thank you for testing on your end.

I updated rabby to 0.92.87 (always a risk as things might break) and the issue seems to go away, which is odd given the slow page load is at the trezor bridge. I wonder if the extension upgrade 'clears certain things' and the trezor bridge page speed is fast again.

Does the trezor bridge page load external resources on page load or is the https://connect.trezor.io/9/popup.html pointing locally?