search

trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
698 stars 247 forks source link

Remove unused/duplicated validation utils #2295

Open szymonlesisz opened 4 years ago

szymonlesisz commented 4 years ago

https://github.com/trezor/trezor-suite/blob/develop/packages/suite/src/utils/wallet/ethUtils.ts

https://github.com/trezor/trezor-suite/blob/develop/packages/suite/src/utils/wallet/validation.ts

https://github.com/trezor/trezor-suite/blob/develop/packages/suite/src/utils/suite/validators.ts

pingpwned commented 3 years ago

It would be also great to have some util to parse valid URL strings and extract protocol, domain or suffix from it

szymonlesisz commented 1 year ago

few duplicates are still there, files were moved to a different directory:

like validateAddress vs isAddressValid. or hex validation functions defined here and there

https://github.com/trezor/trezor-suite/blob/develop/suite-common/wallet-utils/src/ethUtils.ts

https://github.com/trezor/trezor-suite/blob/develop/suite-common/wallet-utils/src/validation.ts

mroz22 commented 2 months ago

as for these, we could probably use @trezor/address-validator but do we actually want to bundle it into connect?