search

trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
706 stars 247 forks source link

Implement bech32 accounts #231

Closed slush0 closed 4 years ago

slush0 commented 5 years ago

New bitcoin wallet is a great chance to implement bech32 bitcoin accounts (=native segwit) and communicate such change to users as a part of technological upgrade between legacy and Next wallet.

Next wallet should handle bech32 accounts as "standard" and move segwit p2sh accounts into Legacy section (together with pre-segwit P2PKH accounts).

@matejzak UI of displaying standard/legacy accounts as well as creating new accounts (both standard and legacy for segwit p2sh and p2pkh) need to be discussed first. The solution in legacy wallet is far from ideal and was designed by engineers. Reimplementing it into Next wallet is an unique chance for improvement.

Implementing #232 is an obvious requirement.

ZdenekSL commented 5 years ago

Implemented into discovery. We dont have bech32 send forms.

maltokyo commented 4 years ago

Why did this get closed?

ZdenekSL commented 4 years ago

Why did this get closed?

Because of the finished development. This feature will be in Suite, our new application. A new wallet with bech32 accounts will be part of it.

maltokyo commented 4 years ago

Great. Thank you. Where can I follow that on GitHub. Would you have the link?

On Tue, 22 Oct 2019 at 16:56, Zdeněk Zippy Slezák notifications@github.com wrote:

Why did this get closed?

Because of the finished development. This feature will be in Suite, our new application. A new wallet with bech32 accounts will be part of it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/trezor/trezor-suite/issues/231?email_source=notifications&email_token=AAKS7W3U3W3SVYWS5WQIV7TQP4IBRA5CNFSM4H7NXBUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6BPJQ#issuecomment-545003430, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKS7W7CG6IES7HO2SNVATLQP4IBRANCNFSM4H7NXBUA .

ZdenekSL commented 4 years ago

In this repository: https://github.com/trezor/trezor-suite

maltokyo commented 4 years ago

Thank you!!

On Tue, 22 Oct 2019 at 17:20, Zdeněk Zippy Slezák notifications@github.com wrote:

In this repository: https://github.com/trezor/trezor-suite

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/trezor/trezor-suite/issues/231?email_source=notifications&email_token=AAKS7W7AIM66BF6T7NJKL2TQP4K3RA5CNFSM4H7NXBUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6EHRA#issuecomment-545014724, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKS7W5XML6JCHONMY5WCDTQP4K3RANCNFSM4H7NXBUA .

maltokyo commented 4 years ago

According to this, Bech32 is coming in Q4 2019, is it still on track?

https://github.com/trezor/trezor-wallet/issues/610#issuecomment-526868878

SimonVillage commented 3 years ago

almost one year later still nothing :)

matejzak commented 3 years ago

Already implemented.

SimonVillage commented 3 years ago

But receiving with trezor wallet is still not possible?

https://wiki.trezor.io/Bech32

Trezor already implemented Bech32 addresses in its firmware, it is possible to send funds to Bech32 addresses using Trezor Wallet. Receiving is possible using Electrum with native segwit (P2WPKH) option.

Edit: Got it, trezor suite is a different product ;)

matejzak commented 3 years ago

Exactly :) Since we are talking, Trezor Suite will go live (public beta) this upcoming Wednesday, and the wiki will get updated to reflect various products. 🤞