Updating from an older firmware shows a fingerprint

trezor / trezor-suite

Trezor Suite Monorepo

https://trezor.io/trezor-suite

Other

695 stars 246 forks source link

Updating from an older firmware shows a fingerprint #4224

Open STew790 opened 3 years ago

STew790 commented 3 years ago

I just tried to update a device with FW 1.6.0 (BL 1.3.2) to the latest FW (1.10.2) on staging Suite (21.9.1 b52f0002ea6364ac8d8a9f733709732bef4c2305) and the Suite forces me to update because of old FW (which is fine) but after connecting the device in BL mode and confirming the update, the device shows me the fingerprint to compare it with Suite but Suite doesn't respond/show this at all, it just gets stuck at 92% (as shown in the screenshot).

Expected result:

Suite shows the fingerprint so that it can be checked against the one on the device

Actual result

Suite just gets stuck on 92% of the FW update and doesn't show anything that corresponds to what is shown on the device.

Screenshot

Originally posted by @STew790 in https://github.com/trezor/trezor-suite/issues/1628#issuecomment-895217126

CruiseMan commented 3 years ago

Dude don't take picture of your fingerprints https://www.iheart.com/content/2021-05-25-drug-dealer-busted-due-to-photo-of-cheese-that-included-his-fingerprints/

wendys-cats commented 3 years ago

Updated from 1.2.0 to the latest via Onboarding.

Update OK Fingerprint shown OK

Info: Suite: APP 21.9.1 8b28b4c5df6eebb039ee30a35fab0016dd30679a Device: T1 1.2.0 OS: Windows 10

Video here

tsusanka commented 2 years ago

Probably fixed, @STew790 will double-check.

STew790 commented 2 years ago

QA NOK Unfortunately, it is not fixed. I just tried this again on staging today and I was able to reproduce it. I tried to update from 1.5.1 FW (1.3.2 BL) and it again stuck on 92% installing FW and the device showed the fingerprint.

Info:

Suite version: web 21.10.1 (aa3adfa347d0416f970a7fae720d3350f29f8916)
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Safari/537.36
OS: Win32
Screen: 1440x900
Device: model 1

STew790 commented 2 years ago

QA NOK This is still present. I just updated from 1.5.2 FW to 1.10.3 Info:

Suite version: web 21.12.1 (e6e9041850c1bdddfcc6590b1f4e6a47c8a40ce8)
Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Safari/537.36
OS: Linux x86_64
Screen: 1920x1080
Device: model 1 1.10.3 regular

prebbz commented 2 years ago

Same thing happened to me, I forgot to note which fw I was upgrading from, but it was to the latest 1.11.1 Suite version: 22.5.3-linux-x86 Device: model 1

The upgrade hung at 92%, clearly waiting for the confirmation of the fingerprint on the device. Is there any reason we don't publish the fingerprints of the fw images on the firmware change log page?

STew790 commented 1 year ago

QA NOK Unfortunately, still present. Info:

Suite version: desktop 23.3.2 (2ab6b568e556d4eebd8c0d3bb04fa278bfe18506)
Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/23.3.2 Chrome/104.0.5112.124 Electron/20.3.12 Safari/537.36
OS: Linux x86_64
Screen: 1920x1080
Device: model 1 1.12.1 Universal (revision 1eb0eb9d91b092e571aac63db4ebff2a07fd8a1f)
Transport: BridgeTransport 2.0.32

sime commented 1 year ago

@STew790 Do we know which versions this error flow come from?

STew790 commented 4 months ago

I just saw this updating from FW 1.6.3. I think it's safe to assume that all those below this might be affected.