trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
724 stars 251 forks source link

Eliminate the risk of getting stuck when loading a hidden wallet #5016

Open wendys-cats opened 2 years ago

wendys-cats commented 2 years ago

Describe the issue It is not always noticeable when server is closed/refuses connection, which can lead to unfortunate situations if the user does not realise the server is down/not responsing, like forever loading wallet either when trying to add hidden wallet or upon re-opening suite. It would be desirable to check responses from electrum server more/to showcase the connection status change in a more visible manner.

Snímek obrazovky 2022-02-28 v 14 59 09

Info:

How to reproduce

  1. Connect to electrum server (BTC full node), preferably one that is in high-usage (like electrum.blockstream.info:50002:s, list of available servers here)
  2. Wait for server to refuse connection
  3. Try to create new (hidden) wallet
  4. Forever loading happens, discovery is not in proccess

Expected behavior Suite will showcase more visibly the server connection status, so user will not try to run discovery when there is no connection to BE.

Additional context This is not a basic functionality and IMHO users utilising it should understand the functionality and possible drawbacks that come with it.

hynek-jina commented 2 years ago

Todo

Unify the path for hidden wallet with regular wallet:

Kixunil commented 2 years ago

Looks like this would greatly benefit from my proposal being implemented. Since that one is stuck, I'm tempted to persuade people to just o with it (perhaps as an experimental feature) out-of-standard. It's designed to not break anything anyway.