trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
724 stars 251 forks source link

Older transaction popping up at the top of the tx export list #5718

Open wendys-cats opened 2 years ago

wendys-cats commented 2 years ago

Describe the bug Suite will in some case place older transactions among the latest in export list. It does not happen consistently, there seems to be no particular trigger that can replicate this every time. First seen last month (3rd June). Suspecting pending transactions (together with labeling?) in export mix up the order. Clearing app cache (with Reset app button in Settings) gets rid of the issue.

Info:

How to reproduce

  1. Download tx export with labeling enabled
  2. See misplaced transactions in the list

Expected behavior Correct sorting (latest to oldest)

Screenshots These exports are only minutes apart, same account, same labeliling (local) image

Export of the same account, circa 15mins after. Labeling is not enabled. image

Local labeling enabled (after switching from first Google, the to Dropbox, to Local last image

bosomt commented 2 years ago

QA OK

fixed in new export

Info:

MatthewDavid1984 commented 1 year ago

This happened to me today while testing exports on windows desktop suite. I had two pending (incoming) transactions and labeling was disabled. Edit: Resetting the app has cleared up the issue even though the transactions are still pending.

Bitcoin_1_20230201T175642.pdf

MatthewDavid1984 commented 1 year ago

Still happening on 23.3.2 (2ab6b568), Win32, TT firmware 2.5.3 universal

sime commented 1 year ago

@MatthewDavid1984 did you find a way to consistently reproduce this? Need to find an example before attempting to fix it.

MatthewDavid1984 commented 1 year ago

@sime afraid not, just tried exporting to pdf on 23.4.1 with 4 txs pending and everything looks fine. i'll let you know if i encounter it again

MatthewDavid1984 commented 1 year ago

Bitcoin_1_20230405T095610.csv @sime i spoke too soon, the csv is messed up but the pdf is fine. but that still doesn't make for a consistent reproduction necessarily, all i can say is have multiple pending transactions in the usual testing wallet and then export.

sime commented 1 year ago

@MatthewDavid1984 and the pending TXs appear in the output?

I'd tempted to remove them from the CSV as pending and TXs shouldn't be trusted.

MatthewDavid1984 commented 1 year ago

yes, pending transactions appear

bosomt commented 1 year ago

QA NOK

pending transactions are already removed but i can see older transactions at top of tx history 🤷🏿 I hope it will get fixed in https://github.com/trezor/trezor-suite/issues/8013

image

image

Info: