trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
724 stars 251 forks source link

Labels are not imported when you import transaction list and labeling is disabled #7170

Open bosomt opened 1 year ago

bosomt commented 1 year ago

Describe the bug Follow up of https://github.com/trezor/trezor-suite/issues/5770 Labels are not imported when you import transaction list and labeling is disabled. Maybe we can warn user or ask him to enable labeling.

Steps to reproduce:

  1. Disable labeling if enabled
  2. Import transaction list from csv file that contains labels
  3. Send transaction
  4. Labels are not present and were omitted without any warning.

Info:

Hannsek commented 1 year ago

I don't see it as a bug. However, we should add modal with something like: importing transaction with labels? turn them on and two buttons: turn on labelling and import the transaction without labels