trezor / trezor-suite

Trezor Suite Monorepo
https://trezor.io/trezor-suite
Other
737 stars 256 forks source link

NFTs section #8004

Open tomasklim opened 1 year ago

tomasklim commented 1 year ago

Screenshot 2024-06-11 at 17 15 36

Describe the bug

Expected behavior I will see NFTs in Suite. I want to be able to filter by ERC721 and ERC1155. Rabby does not distinguish Screenshot 2024-05-02 at 12 24 06

What we get from BlockBook:

ERC1155

{
  "type": "ERC1155",
  "name": "Airdrop at linkredeem.io",
  "contract": "0x43721eF8de94FD33E23eE267546d67CeFdB1968C",
  "transfers": 1,
  "symbol": "NFT",
  "decimals": 18,
  "multiTokenValues": [
    {
      "id": "1",
      "value": "1"
    }
  ]
}

Link to BlockBook: https://matic1.trezor.io/nft/0x43721eF8de94FD33E23eE267546d67CeFdB1968C/1

What is interesting for us? type (ERC-1155) name (Collection) symbol contract address ID (id of NFT, number) amount (how many of specific NFT with specific ID I have) number of transfers

ERC721:

{
  "type": "ERC721",
  "name": "AstronomiaMeta",
  "contract": "0x23A864B6bB94518B0FA41d17f8f52ea38A826457",
  "transfers": 1,
  "symbol": "AstronomiaMeta",
  "decimals": 18,
  "ids": [
    "95729"
  ]
}

Link to BlockBook: https://eth1.trezor.io/nft/0x8506540784ec25A19aB750741A4AB1b6D8790e2c/1

What is interesting for us? type (ERC-720) name (Collection) symbol contract address ID (id of NFT, number, there is always just 1 unique) number of transfers

Icon for recognised NFTs can be fetched from coingecko. It is not circle but square Screenshot 2024-05-02 at 12 22 27

User can have more NFTs from same collection. Do we want to put collections together or just have it as a new token? type (ERC-720) name (Collection) symbol contract address number of transfers

is for collection.

ID (id of NFT, number) amount (how many of specific NFT with specific ID I have)

for item

tomasklim commented 1 year ago

8036 interesting links included

tomasklim commented 5 months ago

@AdamSchinzel let's add it in experimental features for first versions

enjojoy commented 4 weeks ago

NFT -> NFT and HIDDEN -> Two tables for 2 types of tokens

No picture, no receive, no send, copy contract address, show transaction history, link to blockbook where pictures are sown.