Tx with ERC-1155 shows only first NFT available, without # of units - Githubissues

trezor / trezor-suite

Trezor Suite Monorepo

https://trezor.io/trezor-suite

Other

721 stars 251 forks source link

Tx with ERC-1155 shows only first NFT available, without # of units #8036

Open tomasklim opened 1 year ago

tomasklim commented 1 year ago

Describe the bug

Right now, we show only first ERC-1155 within a transaction without units. https://github.com/trezor/trezor-suite/blob/develop/suite-common/wallet-utils/src/transactionUtils.ts#L413 https://github.com/trezor/trezor-suite/blob/develop/packages/suite/src/components/suite/FormattedNftAmount.tsx#L48

Info:

Suite Version: 23.4.0

How to reproduce https://ethereum.org/en/developers/docs/standards/tokens/erc-1155/

Example tx: https://etherscan.io/tx/0xa3074c72e058a29f077f5c478e86dd600623c562939e5ce0a3a3cb65b7a4a706 https://eth1.trezor.io/api/v2/tx/0xa3074c72e058a29f077f5c478e86dd600623c562939e5ce0a3a3cb65b7a4a706

Example address with NFTs: https://eth1.trezor.io/address/0x958B69371e5750Ca8e6436f122322d68b395f781 https://etherscan.io/token/0x05baf9f1961e1ed1dac222a1f97c479441b31b34?a=81#inventory

Expected behavior

shows all NFTs of tx
shows value of NFT

Screenshot 2023-04-07 at 21 51 54

sime commented 1 year ago

@tomasklim Seems like a blockbook problem first?

tomasklim commented 1 year ago

I think the data we are getting are correct